Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loader: Delivery - fix backwards compatibility with older AYON python api #1027

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Loader: Delivery - fix backwards compatibility with older AYON python api #1027

merged 2 commits into from
Nov 25, 2024

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Nov 25, 2024

Changelog Description

The _representation_conversion method converts in-place - it does not return anything

Additional info

Avoids errors:

Traceback (most recent call last):
  File "C:\Users\Maqina-RTX-03\AppData\Local\Ynput\AYON\addons\core_1.0.9+cb.1\ayon_core\plugins\load\delivery.py", line 210, in deliver
    get_representations_delivery_template_data(
  File "C:\Users\Maqina-RTX-03\AppData\Local\Ynput\AYON\addons\core_1.0.9+cb.1\ayon_core\pipeline\delivery.py", line 391, in get_representations_delivery_template_data
    template_data = repre_entity["context"]
TypeError: 'NoneType' object is not subscriptable

Testing notes:

  1. With AYON Python API 1.0.9 in dependency package, delivery tool should still work.

@BigRoy BigRoy added the type: bug Something isn't working label Nov 25, 2024
@BigRoy BigRoy requested a review from iLLiCiTiT November 25, 2024 22:28
@BigRoy BigRoy self-assigned this Nov 25, 2024
@BigRoy BigRoy changed the title Loader: Delivery - fix backwards compatibilit with older AYON python api Loader: Delivery - fix backwards compatibility with older AYON python api Nov 25, 2024
@ynbot ynbot added the size/XS label Nov 25, 2024
@iLLiCiTiT iLLiCiTiT merged commit bdc3c00 into ynput:develop Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

Assignees

@BigRoy BigRoy

Labels
size/XS type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BigRoy @iLLiCiTiT @ynbot